Last active
May 22, 2017 23:40
-
-
Save rdowdy-ucsd/c410c8d4b7fa8ab499608b46753728d1 to your computer and use it in GitHub Desktop.
Jetsons RPG Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Code BEFORE Refactor | |
| /////////////////////////////// | |
| $("#judy-char").on("click", function () { | |
| // choose char | |
| if(charChosen == false) { | |
| $("#game-message").empty(); | |
| // set char | |
| getchar(judy); | |
| charChosen = true; | |
| // display char | |
| $("#judy-char").removeClass("available-char").addClass("chosen-char"); | |
| $("#chosen-char").append(this); | |
| // move to enemies | |
| moveToEnemies(); | |
| } else if ((charChosen == true) && (defenderChosen == false)) { | |
| // choose defender | |
| if($("#judy-char").hasClass("enemy-char")) { | |
| $("#game-message").empty(); | |
| // set enemy | |
| getDefender(judy); | |
| defenderChosen = true; | |
| // add to defender section | |
| $("#judy-char").removeClass("enemy-char").addClass("defender-char"); | |
| $("#defender-section").append(this); | |
| } | |
| } | |
| // Code AFTER Refactor | |
| /////////////////////////// | |
| $("#judy-char").on("click", function () { | |
| onCharacterClick(judy, "#judy-char", this); | |
| }); | |
| function onCharacterClick(charObj, charSelector, element) { | |
| if(charChosen == false) { | |
| $("#game-message").empty(); | |
| // set char | |
| getchar(charObj); | |
| charChosen = true; | |
| // display char | |
| $(charSelector).removeClass("available-char").addClass("chosen-char"); | |
| $("#chosen-char").append(element); | |
| // move to enemies | |
| moveToEnemies(); | |
| } else if ((charChosen == true) && (defenderChosen == false)) { | |
| // choose defender | |
| if($(charSelector).hasClass("enemy-char")) { | |
| $("#game-message").empty(); | |
| // set enemy | |
| getDefender(charObj); | |
| defenderChosen = true; | |
| // add to defender section | |
| $(charSelector).removeClass("enemy-char").addClass("defender-char"); | |
| $("#defender-section").append(element); | |
| } | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment