Jay Fei physician

Pull Request Etiquette

Why do we use a Pull Request workflow?

PRs are a great way of sharing information, and can help us be aware of the changes that are occuring in our codebase. They are also an excellent way of getting peer review on the work that we do, without the cost of working in direct pairs.

Ultimately though, the primary reason we use PRs is to encourage quality in the commits that are made to our code repositories

Done well, the commits (and their attached messages) contained within tell a story to people examining the code at a later date. If we are not careful to ensure the quality of these commits, we silently lose this ability.

	pragma solidity ^0.7.0;

	// Each mining pool that intends to provide flash loans deploys a Loaner contract and transfers ETH to it
	// When testing each bundle, the diff in balance in this contract is taking into account for calculating effective gas price
	// The contract loans funds only on blocks mined by the miner and on zero-gasprice txs
	contract Loaner {
	address immutable owner;

	constructor(address _owner) {
	owner = _owner;

	const hre = require('hardhat');

	const { map } = require('underscore');

	require('dotenv').config();

	const {
	FlashbotsBundleProvider,
	} = require('@flashbots/ethers-provider-bundle');
	const ENS = require('./ENSABI.json');

	// SPDX-License-Identifier: AGPL-3.0-or-later

	// The ABI encoder is necessary, but older Solidity versions should work
	pragma solidity ^0.7.0;
	pragma experimental ABIEncoderV2;

	// These definitions are taken from across multiple dydx contracts, and are
	// limited to just the bare minimum necessary to make flash loans work.
	library Types {
	enum AssetDenomination { Wei, Par }