matheusazzi · May 18, 2023 11:36 · May 18, 2023 · May 18, 2023 · May 19, 2022 · Feb 9, 2018
diff --git a/thing_service.rb b/thing_service.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class ThingService
+class Things::Something
   Result = Data.define(:thing, :errors) do
     def initialize(thing: nil, errors: [])
       super
@@ -39,7 +39,7 @@ def find_or_process_things
 end
 
 # Usage
-result = ThingService.call(params) # => ThingService::Result
+result = Things::Something.call(params) # => Things::Something::Result
 result.successful? # => true
 result.errors # => []
 result.thing # => <ThingRecord...
diff --git a/thing_service.rb b/thing_service.rb
@@ -1,39 +1,45 @@
+# frozen_string_literal: true
+
 class ThingService
-  Result = Struct.new(:errors, :thing, defaults: { errors: [] }) do
+  Result = Data.define(:thing, :errors) do
+    def initialize(thing: nil, errors: [])
+      super
+    end
+
     def successful?
       errors.empty?
     end
   end
 
-  def self.call(params, thing = ThingModel.new)
-    new(params, thing).call
+  def self.call(params, scope = ThingModel)
+    new(params, scope).call
   end
 
   def call
     something = find_or_process_things
 
     if something.successful?
-      Result.new(thing: something...)
+      Result.new(thing: something)
     else
-      Result.new(errors: something.errors, thing: something...)
+      Result.new(errors: something.errors, thing: something)
     end
   end
 
-  def initialize(params, thing)
+  def initialize(params, scope)
     @params = params
-    @thing = thing
+    @scope = scope
   end
   private_class_method :new
 
   private
 
   def find_or_process_things
-    # ...
+    @scope.where(...)
   end
 end
 
 # Usage
-t = ThingService.call(params) # => ThingService::Result
-t.successful? # => true
-t.errors # => []
-t.thing # => <ThingRecord...
+result = ThingService.call(params) # => ThingService::Result
+result.successful? # => true
+result.errors # => []
+result.thing # => <ThingRecord...
diff --git a/thing_service.rb b/thing_service.rb
@@ -1,42 +1,39 @@
 class ThingService
-  attr_reader :thing, :params
-
-  Result = Struct.new(:errors, :things) do
-    def success?
+  Result = Struct.new(:errors, :thing, defaults: { errors: [] }) do
+    def successful?
       errors.empty?
     end
   end
 
-  def self.call(thing = ThingModel.new, params)
-    new(thing, params).call
+  def self.call(params, thing = ThingModel.new)
+    new(params, thing).call
   end
 
   def call
-    @something ||= find_things
+    something = find_or_process_things
 
-    if @something.success?
-      Result.new([...], nil)
+    if something.successful?
+      Result.new(thing: something...)
     else
-      Result.new([], '...')
+      Result.new(errors: something.errors, thing: something...)
     end
   end
 
-  private
-
-  def initialize(thing, params)
-    @thing = thing
+  def initialize(params, thing)
     @params = params
+    @thing = thing
   end
+  private_class_method :new
 
-  def find_things
+  private
+
+  def find_or_process_things
     # ...
   end
 end
 
 # Usage
 t = ThingService.call(params) # => ThingService::Result
-t.success? # => true
+t.successful? # => true
 t.errors # => []
-t.things # => [Thing, Thing, ...]
-
-
+t.thing # => <ThingRecord...
diff --git a/thing_service.rb b/thing_service.rb
@@ -33,4 +33,10 @@ def find_things
   end
 end
 
-ThingService.call(params)
+# Usage
+t = ThingService.call(params) # => ThingService::Result
+t.success? # => true
+t.errors # => []
+t.things # => [Thing, Thing, ...]
+
+
diff --git a/thing_service.rb b/thing_service.rb
@@ -1,36 +1,36 @@
 class ThingService
-  attr_reader :param1, :param2
+  attr_reader :thing, :params
 
-  Result = Struct.new(:success?, :things, :error)
-
-  def self.call(param1, param2)
-    new(param1, param2).call
-  end
-
-  def call
-    do_something
+  Result = Struct.new(:errors, :things) do
+    def success?
+      errors.empty?
+    end
   end
 
-  private
-
-  def initialize(param1, param2)
-    @param1 = param1
-    @param2 = param2
+  def self.call(thing = ThingModel.new, params)
+    new(thing, params).call
   end
 
-  def do_something
+  def call
     @something ||= find_things
 
     if @something.success?
-      Result.new(true, [...], nil)
+      Result.new([...], nil)
     else
-      Result.new(false, [], '...')
+      Result.new([], '...')
     end
   end
 
+  private
+
+  def initialize(thing, params)
+    @thing = thing
+    @params = params
+  end
+
   def find_things
     # ...
   end
 end
 
-ThingService.call(param1, param2)
+ThingService.call(params)
diff --git a/thing_service.rb b/thing_service.rb
@@ -0,0 +1,36 @@
+class ThingService
+  attr_reader :param1, :param2
+
+  Result = Struct.new(:success?, :things, :error)
+
+  def self.call(param1, param2)
+    new(param1, param2).call
+  end
+
+  def call
+    do_something
+  end
+
+  private
+
+  def initialize(param1, param2)
+    @param1 = param1
+    @param2 = param2
+  end
+
+  def do_something
+    @something ||= find_things
+
+    if @something.success?
+      Result.new(true, [...], nil)
+    else
+      Result.new(false, [], '...')
+    end
+  end
+
+  def find_things
+    # ...
+  end
+end
+
+ThingService.call(param1, param2)
No results found