Skip to content

Instantly share code, notes, and snippets.

@maranomynet

maranomynet/mithril-mu.md

Last active August 29, 2015 14:25
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save maranomynet/f138d874f296be3752df to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save maranomynet/f138d874f296be3752df to your computer and use it in GitHub Desktop.
Download ZIP
Feature wrapper for Mithril.js
@barneycarroll
Copy link
Copy Markdown

barneycarroll commented Jul 21, 2015

Hiya @maranomynet, this looks great. Regarding the list of DOM level 0 events, might it be an idea to see whether elements can support the property dynamically? This would avoid the responsibility of having to maintain a list. The condition at line 201 would then become:

!( attrName in document.documentElement )

@maranomynet
Copy link
Copy Markdown
Author

maranomynet commented Jul 21, 2015

Not maintaining a list would be great.

Is attrName in document.documentElement a safe indicator that a level 0 event type is supported?

...hmmm, I guess it must be.

@maranomynet
Copy link
Copy Markdown
Author

maranomynet commented Jul 21, 2015

Changed.

@maranomynet
Copy link
Copy Markdown
Author

maranomynet commented Jul 22, 2015

Actually, this event binding only worked as long as the event handlers didn't change over the lifetime of the element. Now they should update dynamically.

I also changed how it handles cases where transformation functions return a replacement node

@maranomynet
Copy link
Copy Markdown
Author

maranomynet commented Jul 28, 2015

Moved here: https://github.com/maranomynet/mithril-mu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment