makebecoolyeh’s gists

makebecoolyeh / AccountInfo

Created September 28, 2020 16:02

	{#1216
	+"AccountsInfo": {#1217
	+"AccountInfo": array:36 [
	0 => {#1218
	+"Id": 141385416
	+"Name": "2715400 Ontario Inc"
	+"Number": "F110L1NN"
	+"AccountLifeCycleStatus": "Active"
	+"PauseReason": null
	}

makebecoolyeh / Muzaara review

Created September 28, 2020 09:29

	1. .idea не в игноре
	2. Код не соответсвует PSR https://www.php-fig.org/psr/ . Поставь себе php Code Sniffer и настрой связку с PhpStorm , поможет с помощью комбинации кнопок приводит оступы и тд к стандарту. Стандарты - имеется ввиду оступы,пробелы перед '=' названия переменных(нужен canelCase вместо snake_case) и тд.
	3. Хз зачем используешь экраниерование. Почему не узать двойные кавычки?
	'Field \'store\' was not found'
	"Field 'store' was not found"
	4. Я б код контроллеров оборачивал в try catch для обработки всех кейсов.
	5. Для читабельности кода , нужно старатся избегать большое кол-во вложенностей. Например
	foreach ($product['variants'] as $variant) {
	$variant_image_id = !empty($variant['image_id']) ? $variant['image_id'] : null;
	$variant_image_src = null;

makebecoolyeh / gist:5d6dac8d6cb1014f0533cb10334deab3

Created September 13, 2020 07:54

1841399726133

makebecoolyeh / Order #1009

Last active October 20, 2020 07:06

makebecoolyeh / ьуыыфпуы

Created September 7, 2020 15:15

	Hi Andrew,

	Thanks for your email.

	The orderheight for #1009 seems wrong. With two posters and 4 magnetic frames it should be:
	1 + 1 + round( 4 / 6 ) * 20 = 22

	However, I can also see that my JSON contains the wrong package type. It should be JA-Pack-PN-50x70-flat-M

	I have enclosed a new JSON example for the #1009

makebecoolyeh / Order#1010

Last active October 20, 2020 07:10

makebecoolyeh / Order#1008

Last active October 20, 2020 06:56

makebecoolyeh / Order#1006

Last active October 20, 2020 06:46

makebecoolyeh / Order#1007

Last active October 5, 2020 21:23

makebecoolyeh / Order#1007

Last active September 3, 2020 08:01