- Is the functionality correct?
- Are the classes named suitably?
- Are the functions named suitably?
- How's the datastructure being used? Is it the correct DS or it needs improvement?
- Can the classes be further borken into small classes?
- Do we need an interface?
- If it contain functions that can be reused later then are there Utils created for them?
- Can it use already available Util functions?
- Does the large set of input for a function deserve a new bean to be created?
Alexey Dmitriev dmitriev-alexey
dmitriev-alexey
/ GooglePlayServices.kt
Created
December 22, 2020 14:31
— forked from LouisCAD/GooglePlayServices.kt
Allows using Google Play Services Task API in Kotlin Coroutines, plus Play Services availability check made easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import com.google.android.gms.common.GoogleApiAvailability | |
| import com.google.android.gms.tasks.Task | |
| import splitties.init.appCtx | |
| import kotlin.coroutines.experimental.suspendCoroutine | |
| val googleApiAvailability = GoogleApiAvailability.getInstance()!! | |
| inline val playServicesAvailability get() = googleApiAvailability.isGooglePlayServicesAvailable(appCtx) | |
| @JvmName("awaitVoid") | |
| suspend fun Task<Void>.await() = suspendCoroutine<Unit> { continuation -> |
dmitriev-alexey
/ Preference.kt
Created
January 17, 2020 12:11
— forked from Jericho2Code/Preference.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import android.content.SharedPreferences | |
| import kotlin.properties.ReadWriteProperty | |
| import kotlin.reflect.KProperty | |
| class Preference<T>( | |
| private val preferences: SharedPreferences, | |
| private val name: String, | |
| private val default: T | |
| ) : ReadWriteProperty<Any?, T> { |
dmitriev-alexey
/ AndroidJavaCodeReview.md
Created
December 26, 2017 10:28
— forked from srivastavarobin/AndroidJavaCodeReview.md
Code Review Checklist for Android (Java Only)
dmitriev-alexey
/ VIPER Android Example.kt
Created
October 24, 2017 05:34
— forked from marciogranzotto/VIPER Android Example.kt
This is an example of Android development with VIPER in Kotlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| interface LoginContracts { | |
| interface View { | |
| fun showError(message: String) | |
| } | |
| interface Presenter { | |
| fun onDestroy() | |
| fun onLoginButtonPressed(username: String, password: String) | |
| } | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <link rel="import" href="../core-scaffold/core-scaffold.html"> | |
| <link rel="import" href="../core-header-panel/core-header-panel.html"> | |
| <link rel="import" href="../core-menu/core-menu.html"> | |
| <link rel="import" href="../core-item/core-item.html"> | |
| <link rel="import" href="../core-icon-button/core-icon-button.html"> | |
| <link rel="import" href="../core-toolbar/core-toolbar.html"> | |
| <link rel="import" href="../core-menu/core-submenu.html"> | |
| <link rel="import" href="../paper-tabs/paper-tabs.html"> | |
| <link rel="import" href="../paper-tabs/paper-tab.html"> | |
| <link rel="import" href="../core-animated-pages/core-animated-pages.html"> |