Skip to content

Instantly share code, notes, and snippets.

@danmaas

danmaas/expo-notifications+0.8.2.patch

Created December 23, 2020 00:01
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save danmaas/32cfa51b1b4456e98766bc5b30a6be6f to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save danmaas/32cfa51b1b4456e98766bc5b30a6be6f to your computer and use it in GitHub Desktop.
Download ZIP

Revisions

  1. danmaas created this gist Dec 23, 2020.
    20 changes: 20 additions & 0 deletions expo-notifications+0.8.2.patch
    View file
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,20 @@
    diff --git a/node_modules/expo-notifications/ios/EXNotifications/Permissions/EXNotificationPermissionsModule.m b/node_modules/expo-notifications/ios/EXNotifications/Permissions/EXNotificationPermissionsModule.m
    index 4b5fcb6..af045f3 100644
    --- a/node_modules/expo-notifications/ios/EXNotifications/Permissions/EXNotificationPermissionsModule.m
    +++ b/node_modules/expo-notifications/ios/EXNotifications/Permissions/EXNotificationPermissionsModule.m
    @@ -45,10 +45,15 @@ - (instancetype)init
    requester:(UMPromiseResolveBlock)resolve
    rejecter:(UMPromiseRejectBlock)reject)
    {
    + // DJM - revert part of this commit: https://github.com/expo/expo/commit/4500a7536a9d21ce4b1c895d6a11b960be10a82a
    + // which drops the requestedPermission parameter: https://github.com/expo/expo/issues/11414
    + [_requester requestPermissions:requestedPermissions withResolver:resolve rejecter:reject];
    + /*
    [UMPermissionsMethodsDelegate askForPermissionWithPermissionsManager:_permissionsManager
    withRequester:[EXUserFacingNotificationsPermissionsRequester class]
    resolve:resolve
    reject:reject];
    + */
    }

    # pragma mark - UMModuleRegistryConsumer