RReverser · November 2, 2022 01:51 · Nov 2, 2022 · Oct 31, 2022 · Apr 23, 2020 · Jan 29, 2014
diff --git a/.gitignore b/.gitignore
@@ -1 +0,0 @@
-warnglobals.so

diff --git a/ClangWarnGlobals.cpp b/ClangWarnGlobals.cpp
@@ -21,7 +21,7 @@ class PrintGlobalsVisitor : public clang::RecursiveASTVisitor<PrintGlobalsVisito
   bool VisitVarDecl(clang::VarDecl *D) {
     const clang::SourceManager &SM = Context->getSourceManager();
     if (D->hasGlobalStorage() && !D->getType().isConstQualified()) {
-      clang::FullSourceLoc loc = Context->getFullLoc(D->getLocStart());
+      clang::FullSourceLoc loc = Context->getFullLoc(D->getBeginLoc());
       if (!SM.isInSystemHeader(loc)) {
         clang::DiagnosticsEngine &D = *Diagnostics;
         unsigned int id = D.getCustomDiagID(clang::DiagnosticsEngine::Warning, "global variable");

diff --git a/ClangWarnGlobals.cpp b/ClangWarnGlobals.cpp
@@ -49,8 +49,8 @@ class PrintGlobalsConsumer : public clang::ASTConsumer {
 
 class PrintGlobalsAction : public clang::PluginASTAction {
 protected:
-  clang::ASTConsumer *CreateASTConsumer(clang::CompilerInstance &CI, llvm::StringRef) {
-    return new PrintGlobalsConsumer(&CI.getASTContext(), &CI.getDiagnostics());
+    std::unique_ptr<clang::ASTConsumer> CreateASTConsumer(clang::CompilerInstance &CI, llvm::StringRef) {
+        return std::unique_ptr<clang::ASTConsumer>(new PrintGlobalsConsumer(&CI.getASTContext(), &CI.getDiagnostics()));
   }
 
   bool ParseArgs(const clang::CompilerInstance &CI,
@@ -63,4 +63,4 @@ class PrintGlobalsAction : public clang::PluginASTAction {
 }
 
 static clang::FrontendPluginRegistry::Add<PrintGlobalsAction>
-X("warn-globals", "generate warnings for non-const global variables");
+X("warn-globals", "generate warnings for non-const global variables");
diff --git a/Makefile b/Makefile
@@ -1,9 +1,9 @@
 warnglobals.so: ClangWarnGlobals.cpp
-	clang++ -g -O0 -std=c++98 -shared -fPIC $$(llvm-config --cflags --ldflags --libs support mc) -o "$@" $^ -lclang
+	clang++ -g -O0 -shared -fPIC $$(llvm-config --cflags --cxxflags --ldflags --libs support mc) -o "$@" $^ -lclang
 
 .PHONY: run
 run: warnglobals.so
-	clang++ -Xclang -load -Xclang ./warnglobals.so -Xclang -plugin -Xclang warn-globals test.cpp
+	clang++ -Xclang -load -Xclang ./warnglobals.so -Xclang -add-plugin -Xclang warn-globals test.cpp
 
 .PHONY: clean
 clean:

diff --git a/ClangWarnGlobals.cpp b/ClangWarnGlobals.cpp
@@ -5,50 +5,6 @@
 //
 // Written by John Bartholomew <jpa.bartholomew@gmail.com>
 
-// Makefile
-#if 0
-warnglobals.so: WarnGlobals.cpp
-	clang++ -std=c++98 -shared -fPIC $$(llvm-config --cflags --libs support mc) -o "$@" $^ -L/usr/lib/llvm/ -lclang
-
-.PHONY: run
-run: warnglobals.so
-	clang++ -fsyntax-only -Xclang -load -Xclang ./warnglobals.so -Xclang -plugin -Xclang warn-globals test.cpp
-
-.PHONY: clean
-clean:
-	rm -f warnglobals.so
-#endif
-
-// TEST FILE -- copy out to test.cpp
-#if 0
-#include <iostream>
-
-static int s_some_global = 42;
-static const int s_some_const_global = 42;
-
-static void some_function_with_a_static() {
-  static int s_static_local = 42;
-}
-
-namespace some_namespace {
-  namespace some_sub_namespace {
-    int public_global = 42;
-  }
-
-  class some_class {
-    static const int static_const_member = 42;
-    static int static_member;
-  };
-}
-
-int some_namespace::some_class::static_member = 42;
-
-int main(int argc, char **argv) {
-  std::cout << "global value: " << s_some_global << "\n";
-  return 0;
-}
-#endif
-
 #include "clang/Frontend/FrontendPluginRegistry.h"
 #include "clang/AST/AST.h"
 #include "clang/AST/ASTConsumer.h"

diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+warnglobals.so
diff --git a/ClangWarnGlobals.cpp b/ClangWarnGlobals.cpp
@@ -0,0 +1,110 @@
+// -Wglobals Clang plugin
+//
+// Based on example plugins and searching Clang's API documentation.
+// BEWARE! This is my first ever attempt at a Clang plugin.
+//
+// Written by John Bartholomew <jpa.bartholomew@gmail.com>
+
+// Makefile
+#if 0
+warnglobals.so: WarnGlobals.cpp
+	clang++ -std=c++98 -shared -fPIC $$(llvm-config --cflags --libs support mc) -o "$@" $^ -L/usr/lib/llvm/ -lclang
+
+.PHONY: run
+run: warnglobals.so
+	clang++ -fsyntax-only -Xclang -load -Xclang ./warnglobals.so -Xclang -plugin -Xclang warn-globals test.cpp
+
+.PHONY: clean
+clean:
+	rm -f warnglobals.so
+#endif
+
+// TEST FILE -- copy out to test.cpp
+#if 0
+#include <iostream>
+
+static int s_some_global = 42;
+static const int s_some_const_global = 42;
+
+static void some_function_with_a_static() {
+  static int s_static_local = 42;
+}
+
+namespace some_namespace {
+  namespace some_sub_namespace {
+    int public_global = 42;
+  }
+
+  class some_class {
+    static const int static_const_member = 42;
+    static int static_member;
+  };
+}
+
+int some_namespace::some_class::static_member = 42;
+
+int main(int argc, char **argv) {
+  std::cout << "global value: " << s_some_global << "\n";
+  return 0;
+}
+#endif
+
+#include "clang/Frontend/FrontendPluginRegistry.h"
+#include "clang/AST/AST.h"
+#include "clang/AST/ASTConsumer.h"
+#include "clang/AST/RecursiveASTVisitor.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+namespace {
+
+class PrintGlobalsVisitor : public clang::RecursiveASTVisitor<PrintGlobalsVisitor> {
+public:
+  explicit PrintGlobalsVisitor(clang::ASTContext *Context, clang::DiagnosticsEngine *Diagnostics)
+    : Context(Context), Diagnostics(Diagnostics) {}
+
+  bool VisitVarDecl(clang::VarDecl *D) {
+    const clang::SourceManager &SM = Context->getSourceManager();
+    if (D->hasGlobalStorage() && !D->getType().isConstQualified()) {
+      clang::FullSourceLoc loc = Context->getFullLoc(D->getLocStart());
+      if (!SM.isInSystemHeader(loc)) {
+        clang::DiagnosticsEngine &D = *Diagnostics;
+        unsigned int id = D.getCustomDiagID(clang::DiagnosticsEngine::Warning, "global variable");
+        D.Report(loc, id);
+      }
+    }
+    return true;
+  }
+private:
+  clang::ASTContext *Context;
+  clang::DiagnosticsEngine *Diagnostics;
+};
+
+class PrintGlobalsConsumer : public clang::ASTConsumer {
+public:
+  explicit PrintGlobalsConsumer(clang::ASTContext *Context, clang::DiagnosticsEngine *Diagnostics)
+    : Visitor(Context, Diagnostics) {}
+
+  virtual void HandleTranslationUnit(clang::ASTContext &Context) {
+    Visitor.TraverseDecl(Context.getTranslationUnitDecl());
+  }
+private:
+  PrintGlobalsVisitor Visitor;
+};
+
+class PrintGlobalsAction : public clang::PluginASTAction {
+protected:
+  clang::ASTConsumer *CreateASTConsumer(clang::CompilerInstance &CI, llvm::StringRef) {
+    return new PrintGlobalsConsumer(&CI.getASTContext(), &CI.getDiagnostics());
+  }
+
+  bool ParseArgs(const clang::CompilerInstance &CI,
+                 const std::vector<std::string>& args) {
+    // To be written...
+    return true;
+  }
+};
+
+}
+
+static clang::FrontendPluginRegistry::Add<PrintGlobalsAction>
+X("warn-globals", "generate warnings for non-const global variables");
diff --git a/Makefile b/Makefile
@@ -0,0 +1,10 @@
+warnglobals.so: ClangWarnGlobals.cpp
+	clang++ -g -O0 -std=c++98 -shared -fPIC $$(llvm-config --cflags --ldflags --libs support mc) -o "$@" $^ -lclang
+
+.PHONY: run
+run: warnglobals.so
+	clang++ -Xclang -load -Xclang ./warnglobals.so -Xclang -plugin -Xclang warn-globals test.cpp
+
+.PHONY: clean
+clean:
+	rm -f warnglobals.so
diff --git a/test.cpp b/test.cpp
@@ -0,0 +1,26 @@
+#include <iostream>
+
+static int s_some_global = 42;
+static const int s_some_const_global = 42;
+
+static void some_function_with_a_static() {
+  static int s_static_local = 42;
+}
+
+namespace some_namespace {
+  namespace some_sub_namespace {
+    int public_global = 42;
+  }
+
+  class some_class {
+    static const int static_const_member = 42;
+    static int static_member;
+  };
+}
+
+int some_namespace::some_class::static_member = 42;
+
+int main(int argc, char **argv) {
+  std::cout << "global value: " << s_some_global << "\n";
+  return 0;
+}
No results found