Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Select an option

  • Save Brandon-Lyons/32bc410f77138f44db058b136ccbbb52 to your computer and use it in GitHub Desktop.

Select an option

Save Brandon-Lyons/32bc410f77138f44db058b136ccbbb52 to your computer and use it in GitHub Desktop.
Updated Account Creation
They are several changes that the new design requires.
1. Reorganizing †he SignUpForm component:
I'm taking the SignUpForm component and breaking it down into smaller child components organized by the sections in the new design. This will make the components easier to handle and we can better achieve the design.
2. Tracking state
There is data from the form that we must keep track of for features of the new design. For example, when the user selects an education level, the background of the page must change and the tab shows Studying/Teaching in #{eduactaion_level}. We will keep track of these changes by passing the state from the child components to the parent component (SignUpForm) which will keep the state and display it appropriately.
3. Filter Institutions by Education Level
To filter by education level we must first collect the attribute to filter on. After talking with Jason Justice, he suggested using the kind attribute from the ringgold list and look for "academic" (for higher ed) and "school" (for k-12). I have adjusted the institutions importer and the vst-api-client gem to collect the kind. I have also changed the InstitutionSearch model to use the kind param.
4. Remove the State Parameter from Institution Select
Another part of the design is to not ask for the state/province when selecting the institution. Part of this change will be using the current_region as the default country selection. We will then present an institution select filtered by country and education level. If the user chooses an institution that has a name that is common with other institutions in that country, we will then present a state select to clarify their institution selection.
5. CSS/Javascript
This can be simple, but tedious. Apply the new CSS and Javascript changes. This includes: changing the form to use a wizard flow with accordian animations, background change on education level selection, displaying form selections and entries in tabs (ex. "Studying in College" if they chose the student role and collge education level), and adding the ability to re-open a previous tab to make changes.
@base10
Copy link
Copy Markdown

base10 commented May 10, 2018

I think most of this looks good, thanks for putting it together.

On No. 3, with the following:

I have adjusted the institutions importer and the vst-api-client gem to collect the kind. I have also changed the InstitutionSearch model to use the kind param.

I left feedback on the PR because I'm concerned there's a need to migrate the existing Institution data to account for the field realignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment